docs: re-add Servers tutorial and change code snippet
#2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - Re-added the `Severs tutorial` in the next-major-spec branch. - Changed the code snippet to match v3.
AnimeshKumar923
requested review from
quetzalliwrites and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AnimeshKumar923
changed the title
Servers tutorial and change code snippetServers tutorial and change code snippet
derberg
previously approved these changes
Nov 8, 2023
There was a problem hiding this comment.
@AnimeshKumar923 perfectly updated! 👏🏼
@alequetzalli you can approve and merge. Only example had to be changed. Animesh re-added existing tutorial and only modified the example - text unchanged
Thank you! My pleasure Sir! |
derberg
reviewed
Nov 9, 2023
applied suggestion from: asyncapi#2275 (comment) Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
derberg
previously approved these changes
Nov 9, 2023
quetzalliwrites
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
@derberg, i think we need you to hit approve again? yes? or no? here I go and see what happens 😂
|
/rtm |
|
oh nvm this one didnt re request a review for some reason O_O that makes no sense to me, but hey, it's merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Fixes #1859